[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] softmmu/physmem: Fix input parameters for flatview_access_al
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH] softmmu/physmem: Fix input parameters for flatview_access_allowed() |
|
Date: |
Wed, 22 Jun 2022 17:02:56 -0400 |
On Wed, Jun 22, 2022 at 09:28:39AM +0800, Zhenzhong Duan wrote:
> The comment of flatview_access_allowed() suggests to pass address
> within that memory region, this isn't ture in some call sites.
>
> This makes qemu log in flatview_access_allowed() confusing and
> potential risk if the input parameter will be checked in the future.
>
> Fixes: 3ab6fdc91b72 ("softmmu/physmem: Introduce MemTxAttrs::memory field and
> MEMTX_ACCESS_ERROR")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Thanks,
--
Peter Xu