[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/10] target/loongarch: Add lock when writing timer clear reg
From: |
Xiaojuan Yang |
Subject: |
[PATCH 10/10] target/loongarch: Add lock when writing timer clear reg |
Date: |
Wed, 22 Jun 2022 18:43:01 +0800 |
There is such error info when running linux kernel:
tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked()).
calling stack:
#0 in raise () at /lib64/libc.so.6
#1 in abort () at /lib64/libc.so.6
#2 in g_assertion_message_expr.cold () at /lib64/libglib-2.0.so.0
#3 in g_assertion_message_expr () at /lib64/libglib-2.0.so.0
#4 in tcg_handle_interrupt (cpu=0x632000030800, mask=2) at
../accel/tcg/tcg-accel-ops.c:79
#5 in cpu_interrupt (cpu=0x632000030800, mask=2) at ../softmmu/cpus.c:248
#6 in loongarch_cpu_set_irq (opaque=0x632000030800, irq=11, level=0)
at ../target/loongarch/cpu.c:100
#7 in helper_csrwr_ticlr (env=0x632000039440, val=1) at
../target/loongarch/csr_helper.c:85
#8 in code_gen_buffer ()
#9 in cpu_tb_exec (cpu=0x632000030800, itb=0x7fff946ac280,
tb_exit=0x7ffe4fcb6c30)
at ../accel/tcg/cpu-exec.c:358
Add mutex iothread lock around loongarch_cpu_set_irq in csrwr_ticlr() to
fix the bug.
Signed-off-by: Xiaojuan Yang <yangxiaojuan@loongson.cn>
---
target/loongarch/csr_helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/loongarch/csr_helper.c b/target/loongarch/csr_helper.c
index 24a9389364..7e02787895 100644
--- a/target/loongarch/csr_helper.c
+++ b/target/loongarch/csr_helper.c
@@ -81,7 +81,9 @@ target_ulong helper_csrwr_ticlr(CPULoongArchState *env,
target_ulong val)
int64_t old_v = 0;
if (val & 0x1) {
+ qemu_mutex_lock_iothread();
loongarch_cpu_set_irq(cpu, IRQ_TIMER, 0);
+ qemu_mutex_unlock_iothread();
}
return old_v;
}
--
2.31.1
- [PATCH 00/10] Add functions for LoongArch virt machine, Xiaojuan Yang, 2022/06/22
- [PATCH 02/10] hw/loongarch: Add fw_cfg table support, Xiaojuan Yang, 2022/06/22
- [PATCH 08/10] hw/loongarch: Fix ipi device access of 64bits, Xiaojuan Yang, 2022/06/22
- [PATCH 04/10] hw/loongarch: Add linux kernel booting support, Xiaojuan Yang, 2022/06/22
- [PATCH 03/10] hw/loongarch: Add uefi bios loading support, Xiaojuan Yang, 2022/06/22
- [PATCH 06/10] hw/loongarch: Add acpi ged support, Xiaojuan Yang, 2022/06/22
- [PATCH 10/10] target/loongarch: Add lock when writing timer clear reg,
Xiaojuan Yang <=
- [PATCH 07/10] hw/loongarch: Add fdt support, Xiaojuan Yang, 2022/06/22
- [PATCH 05/10] hw/loongarch: Add smbios support, Xiaojuan Yang, 2022/06/22
- [PATCH 09/10] target/loongarch: Fix the meaning of ECFG reg's VS field, Xiaojuan Yang, 2022/06/22
- [PATCH 01/10] hw/loongarch: rename macro prefix LS_PCI to LS7A_PCI, Xiaojuan Yang, 2022/06/22