[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/4] migration: Change zero_copy_send from migration param
From: |
Juan Quintela |
Subject: |
Re: [PATCH v4 4/4] migration: Change zero_copy_send from migration parameter to migration capability |
Date: |
Mon, 20 Jun 2022 17:51:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Peter Xu <peterx@redhat.com> wrote:
> On Mon, Jun 20, 2022 at 02:39:45AM -0300, Leonardo Bras wrote:
>> When originally implemented, zero_copy_send was designed as a Migration
>> paramenter.
>>
>> But taking into account how is that supposed to work, and how
>> the difference between a capability and a parameter, it only makes sense
>> that zero-copy-send would work better as a capability.
>>
>> Taking into account how recently the change got merged, it was decided
>> that it's still time to make it right, and convert zero_copy_send into
>> a Migration capability.
>>
>> Signed-off-by: Leonardo Bras <leobras@redhat.com>
>
> I assume this is a request from Libvirt? We don't have a release yet so
> yeah probably we still have time..
>
> Acked-by: Peter Xu <peterx@redhat.com>
Livirt already have a concept of migration capabilities (bools) that
lets layered products to check/discover/etc. Putting it there instead
of one parameter makes their life much easier (i.e. more common code).
As this code hasn't been in a stable release yet, I think it is ok.
Later, Juan.
- [PATCH v4 1/4] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability, (continued)