[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 18/18] block_job_query: remove atomic read
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v7 18/18] block_job_query: remove atomic read |
Date: |
Thu, 16 Jun 2022 09:18:35 -0400 |
Not sure what the atomic here was supposed to do, since job.busy
is protected by the job lock. Since the whole function
is called under job_mutex, just remove the atomic.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
blockjob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockjob.c b/blockjob.c
index 8b9e10813d..d84ddca363 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -324,7 +324,7 @@ BlockJobInfo *block_job_query_locked(BlockJob *job, Error
**errp)
info = g_new0(BlockJobInfo, 1);
info->type = g_strdup(job_type_str(&job->job));
info->device = g_strdup(job->job.id);
- info->busy = qatomic_read(&job->job.busy);
+ info->busy = job->job.busy;
info->paused = job->job.pause_count > 0;
info->offset = progress_current;
info->len = progress_total;
--
2.31.1
- Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held, (continued)
- Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held, Emanuele Giuseppe Esposito, 2022/06/28
- Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held, Vladimir Sementsov-Ogievskiy, 2022/06/28
- Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held, Emanuele Giuseppe Esposito, 2022/06/28
- Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held, Vladimir Sementsov-Ogievskiy, 2022/06/28
- Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held, Vladimir Sementsov-Ogievskiy, 2022/06/28
- Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held, Emanuele Giuseppe Esposito, 2022/06/28
- Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held, Vladimir Sementsov-Ogievskiy, 2022/06/28
[PATCH v7 18/18] block_job_query: remove atomic read,
Emanuele Giuseppe Esposito <=
[PATCH v7 13/18] job.h: define unlocked functions, Emanuele Giuseppe Esposito, 2022/06/16
[PATCH v7 04/18] aio-wait.h: introduce AIO_WAIT_WHILE_UNLOCKED, Emanuele Giuseppe Esposito, 2022/06/16
[PATCH v7 17/18] job.c: enable job lock/unlock and remove Aiocontext locks, Emanuele Giuseppe Esposito, 2022/06/16
[PATCH v7 14/18] commit and mirror: create new nodes using bdrv_get_aio_context, and not the job aiocontext, Emanuele Giuseppe Esposito, 2022/06/16
[PATCH v7 06/18] jobs: protect jobs with job_lock/unlock, Emanuele Giuseppe Esposito, 2022/06/16
[PATCH v7 08/18] jobs: use job locks also in the unit tests, Emanuele Giuseppe Esposito, 2022/06/16
[PATCH v7 12/18] block_job: rename block_job functions called with job_mutex held, Emanuele Giuseppe Esposito, 2022/06/16