[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/7] tests/9pfs: walk to non-existent dir
From: |
Christian Schoenebeck |
Subject: |
[PULL 1/7] tests/9pfs: walk to non-existent dir |
Date: |
Thu, 16 Jun 2022 13:00:04 +0200 |
Expect ENOENT Rlerror response when trying to walk to a
non-existent directory.
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Based-on: <E1nTpyU-0000yR-9o@lizzy.crudebyte.com>
Message-Id:
<1f5aa50ace3ba3861ea31e8888367518282065a6.1647339025.git.qemu_oss@crudebyte.com>
---
tests/qtest/virtio-9p-test.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index e28c71bd8f..b3837546be 100644
--- a/tests/qtest/virtio-9p-test.c
+++ b/tests/qtest/virtio-9p-test.c
@@ -606,6 +606,25 @@ static uint32_t do_walk(QVirtio9P *v9p, const char *path)
return fid;
}
+/* utility function: walk to requested dir and expect passed error response */
+static void do_walk_expect_error(QVirtio9P *v9p, const char *path, uint32_t
err)
+{
+ char **wnames;
+ P9Req *req;
+ uint32_t _err;
+ const uint32_t fid = genfid();
+
+ int nwnames = split(path, "/", &wnames);
+
+ req = v9fs_twalk(v9p, 0, fid, nwnames, wnames, 0);
+ v9fs_req_wait_for_reply(req, NULL);
+ v9fs_rlerror(req, &_err);
+
+ g_assert_cmpint(_err, ==, err);
+
+ split_free(&wnames);
+}
+
static void fs_version(void *obj, void *data, QGuestAllocator *t_alloc)
{
alloc = t_alloc;
@@ -974,6 +993,15 @@ static void fs_walk_no_slash(void *obj, void *data,
QGuestAllocator *t_alloc)
g_free(wnames[0]);
}
+static void fs_walk_nonexistent(void *obj, void *data, QGuestAllocator
*t_alloc)
+{
+ QVirtio9P *v9p = obj;
+ alloc = t_alloc;
+
+ do_attach(v9p);
+ do_walk_expect_error(v9p, "non-existent", ENOENT);
+}
+
static void fs_walk_dotdot(void *obj, void *data, QGuestAllocator *t_alloc)
{
QVirtio9P *v9p = obj;
@@ -1409,6 +1437,8 @@ static void register_virtio_9p_test(void)
&opts);
qos_add_test("synth/walk/dotdot_from_root", "virtio-9p",
fs_walk_dotdot, &opts);
+ qos_add_test("synth/walk/non_existent", "virtio-9p", fs_walk_nonexistent,
+ &opts);
qos_add_test("synth/lopen/basic", "virtio-9p", fs_lopen, &opts);
qos_add_test("synth/write/basic", "virtio-9p", fs_write, &opts);
qos_add_test("synth/flush/success", "virtio-9p", fs_flush_success,
--
2.30.2
- [PULL 0/7] 9p queue 2022-06-16, Christian Schoenebeck, 2022/06/16
- [PULL 1/7] tests/9pfs: walk to non-existent dir,
Christian Schoenebeck <=
- [PULL 2/7] tests/9pfs: Twalk with nwname=0, Christian Schoenebeck, 2022/06/16
- [PULL 3/7] tests/9pfs: compare QIDs in fs_walk_none() test, Christian Schoenebeck, 2022/06/16
- [PULL 4/7] 9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk(), Christian Schoenebeck, 2022/06/16
- [PULL 5/7] 9pfs: fix 'Twalk' to only send error if no component walked, Christian Schoenebeck, 2022/06/16
- [PULL 6/7] tests/9pfs: guard recent 'Twalk' behaviour fix, Christian Schoenebeck, 2022/06/16
- [PULL 7/7] tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent, Christian Schoenebeck, 2022/06/16
- Re: [PULL 0/7] 9p queue 2022-06-16, Richard Henderson, 2022/06/16