[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/vm: do not specify -bios option
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH] tests/vm: do not specify -bios option |
|
Date: |
Thu, 16 Jun 2022 11:29:49 +0100 |
|
User-agent: |
Mutt/2.2.1 (2022-02-19) |
On Thu, Jun 16, 2022 at 10:30:25AM +0200, Paolo Bonzini wrote:
> When running from the build tree, the executable is able to find
> the BIOS on its own; when running from the source tree, a firmware
> blob should already be installed and there is no guarantee that
> the one in the source tree works with the QEMU that is being used for
> the installation.
>
> Just remove the -bios option, since it is unnecessary and in fact
> there are other x86 VM tests that do not bother specifying it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/vm/fedora | 1 -
> tests/vm/freebsd | 1 -
> tests/vm/netbsd | 1 -
> tests/vm/openbsd | 1 -
> 4 files changed, 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|