qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 4/4] net: convert to use qemu_find_file to locate bridge h

From: Paolo Bonzini
Subject: Re: [PATCH v3 4/4] net: convert to use qemu_find_file to locate bridge helper
Date: Wed, 15 Jun 2022 13:42:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 
On 6/15/22 12:52, Daniel P. Berrangé wrote:
+ case QEMU_FILE_TYPE_HELPER: 
+        rel_install_dir = "";
+        rel_build_dir = "";
+        default_install_dir = default_helper_dir;
+        break;
+
You're replacing ad hoc rules in Akihiko's meson.build with an ad hoc enum + the corresponding "case"s here in qemu_find_file(). There is duplication anyway, in this case between Meson and QEMU (plus QEMU needs to know about two filesystem layouts). 

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]