qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 0/4] cutils: Introduce bundle mechanism


From: Paolo Bonzini
Subject: Re: [PATCH v4 0/4] cutils: Introduce bundle mechanism
Date: Wed, 15 Jun 2022 13:02:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 6/15/22 10:30, Daniel P. Berrangé wrote:
I don't think this is an attractive approach to the problem,
because it results in us adding a bunch of meson rules to
simulate 'make install' within the build dir. This is undesirable
clutter IMHO, and can be solved more simply by just modifying the
qemu_find_file() method.

The core problem is the impl of qemu_find_file is taking the wrong
approach, in several ways, but mostly because of its use of a single
'data_dirs' array for all types of file. This is bad because it
has the assumption that build dir and install dir layouts match,
and second because when we add extra firmware data dirs, we don't
want this used for non-firmware files.

We need to separate out the handling of different types of resources
for this to work correctly.

In some sense this is what Akihiko did - instead of separating them in qemu_find_file(), the "pre-install" layout separates them in the filesystem. While I had remarks on the implementation I think it's a sensible approach.

The pre-install directory could even be created as a custom_target, using the JSON files from Meson introspection.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]