[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag
From: |
David Hildenbrand |
Subject: |
Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag |
Date: |
Wed, 15 Jun 2022 10:24:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 |
On 14.06.22 14:13, Julia Suvorova wrote:
> On Tue, Jun 14, 2022 at 11:50 AM David Hildenbrand <david@redhat.com> wrote:
>>
>> On 14.06.22 10:54, Igor Mammedov wrote:
>>> On Mon, 13 Jun 2022 16:09:53 +0100
>>> Stefan Hajnoczi <stefanha@redhat.com> wrote:
>>>
>>>> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote:
>>>>> On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi <stefanha@redhat.com>
>>>>> wrote:
>>>>>>
>>>>>> On Tue, May 31, 2022 at 04:51:47PM +0200, Julia Suvorova wrote:
>>>>>>> In the ACPI specification [1], the 'unarmed' bit is set when a device
>>>>>>> cannot accept a persistent write. This means that when a memdev is
>>>>>>> read-only, the 'unarmed' flag must be turned on. The logic is correct,
>>>>>>> just changing the error message.
>>>>>>>
>>>>>>> [1] ACPI NFIT NVDIMM Region Mapping Structure "NVDIMM State Flags" Bit 3
>>>>>>>
>>>>>>> Signed-off-by: Julia Suvorova <jusual@redhat.com>
>>>>>>> ---
>>>>>>> hw/mem/nvdimm.c | 2 +-
>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>>>>
>>>>> It seems like Xiao is not active, whose tree should this patch go to?
>>
>> Is that a temporary or a permanent thing? Do we know?
>
> No idea. But his last signed-off was three years ago.
I sent a patch to Xiao, asking if he's still active in QEMU. If I don't
get a reply this week, I'll move forward with proposing an update to
MAINTAINERS as described.
--
Thanks,
David / dhildenb
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag, Julia Suvorova, 2022/06/13
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag, Stefan Hajnoczi, 2022/06/13
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag, Igor Mammedov, 2022/06/14
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag, David Hildenbrand, 2022/06/14
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag, Julia Suvorova, 2022/06/14
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag,
David Hildenbrand <=
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag, Xiao Guangrong, 2022/06/15
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag, David Hildenbrand, 2022/06/15
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag, Xiao Guangrong, 2022/06/17
- Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag, Igor Mammedov, 2022/06/14