Re: [PATCH v4 2/2] target/xtensa: Use semihosting/syscalls.h

[Richard Henderson]

On 6/13/22 18:06, Max Filippov wrote:
> > +++ b/hw/xtensa/sim.c
> > @@ -87,9 +87,6 @@ XtensaCPU *xtensa_sim_common_init(MachineState *machine)
> >           xtensa_create_memory_regions(&sysram, "xtensa.sysram",
> >                                        get_system_memory());
> >       }
> > -    if (serial_hd(0)) {
> > -        xtensa_sim_open_console(serial_hd(0));
> > -    }
>
> Do I understand correctly that the sim machine will no longer
> support the -serial option with this change?

No, -serial is still fine.  However, -serial is no longer the semihosting "console" -- 
that will get its own output stream.

> > +#include "semihosting/syscalls.h"
>
> This does not build on top of the current master, is there a branch where
> it's buildable?

Yes, see the cover letter and the Based-on tag, or
20220608053650.811947-1-richard.henderson@linaro.org/">https://patchew.org/QEMU/20220608053650.811947-1-richard.henderson@linaro.org/

and the git fetch link there.


git fetch https://github.com/patchew-project/qemu 
tags/patchew/20220608053650.811947-1-richard.henderson@linaro.org

> > -#ifdef ENOTBLK
> > -    case ENOTBLK:   return TARGET_ENOTBLK;
> > -#endif
>
> AFAIR there were reports that qemu doesn't build on some
> systems because they were missing ENOTBLK and other
> error codes that were made conditional here.

Ok, I'll have a dig back.

> > +    E(LOOP);
>
> I'm not sure mangling error code names is a good idea.

Mangling?


r~