[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 2/2] target/xtensa: Use semihosting/syscalls.h

From: Richard Henderson
Subject: Re: [PATCH v4 2/2] target/xtensa: Use semihosting/syscalls.h
Date: Mon, 13 Jun 2022 21:41:44 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1

On 6/13/22 18:06, Max Filippov wrote:
+++ b/hw/xtensa/sim.c
@@ -87,9 +87,6 @@ XtensaCPU *xtensa_sim_common_init(MachineState *machine)
          xtensa_create_memory_regions(&sysram, "xtensa.sysram",
-    if (serial_hd(0)) {
-        xtensa_sim_open_console(serial_hd(0));
-    }

Do I understand correctly that the sim machine will no longer
support the -serial option with this change?

No, -serial is still fine. However, -serial is no longer the semihosting "console" -- that will get its own output stream.

+#include "semihosting/syscalls.h"

This does not build on top of the current master, is there a branch where
it's buildable?

Yes, see the cover letter and the Based-on tag, or

and the git fetch link there.

git fetch https://github.com/patchew-project/qemu tags/patchew/20220608053650.811947-1-richard.henderson@linaro.org

-#ifdef ENOTBLK
-    case ENOTBLK:   return TARGET_ENOTBLK;

AFAIR there were reports that qemu doesn't build on some
systems because they were missing ENOTBLK and other
error codes that were made conditional here.

Ok, I'll have a dig back.

+    E(LOOP);

I'm not sure mangling error code names is a good idea.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]