qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/11] bsd-user: Implement dup and dup2


From: Warner Losh
Subject: Re: [PATCH 09/11] bsd-user: Implement dup and dup2
Date: Mon, 13 Jun 2022 15:54:18 -0600



On Mon, Jun 13, 2022 at 1:53 PM Richard Henderson <richard.henderson@linaro.org> wrote:
On 6/12/22 13:48, Warner Losh wrote:
> Signed-off-by: Stacey Son <sson@FreeBSD.org>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
>   bsd-user/bsd-file.h           | 14 ++++++++++++++
>   bsd-user/freebsd/os-syscall.c |  8 ++++++++
>   2 files changed, 22 insertions(+)
>
> diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h
> index 500d6ba78b9..73263ba482f 100644
> --- a/bsd-user/bsd-file.h
> +++ b/bsd-user/bsd-file.h
> @@ -491,4 +491,18 @@ static abi_long do_bsd___getcwd(abi_long arg1, abi_long arg2)
>       return get_errno(ret);
>   }
>   
> +/* dup(2) */
> +static abi_long do_bsd_dup(abi_long arg1)
> +{
> +
> +    return get_errno(dup(arg1));
> +}
> +
> +/* dup2(2) */
> +static abi_long do_bsd_dup2(abi_long arg1, abi_long arg2)
> +{
> +
> +    return get_errno(dup2(arg1, arg2));
> +}

Extra lines.  Is this some setting in your editor?  Otherwise,

It's an odd quirk of FreeBSD's style from the 90s until 2020... I'm totally blind to
it most of the time...
 
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks for this, and all the other reviews.

Warner 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]