Re: [PATCH 08/11] bsd-user: Implement rmdir and undocumented -_getcwd

[Richard Henderson]

On 6/12/22 13:48, Warner Losh wrote:
> Implemenet rmdir and __getcwd. Declare __getcwd as extern because
> there's no installed FreeBSD header that has it. It's used internally by
> libc, which doesn't provide an external declaration, but does export the
> symbol.

Typo in subject: s/-/_/.

> @@ -55,6 +55,7 @@ extern struct iovec *lock_iovec(int type, abi_ulong 
> target_addr, int count,
>           int copy);
>   extern void unlock_iovec(struct iovec *vec, abi_ulong target_addr, int count,
>           int copy);
> +extern int __getcwd(char *path, size_t len);

Do you really want to rely on this export?
Unless it does something special, I'd just declare a local version of the syscall as you 
do with safe_*.

> +/* undocumented __getcwd(char *buf, size_t len)  system call */

Surely the syscall itself is documented?


r~