[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] ui: move 'pc-bios/keymaps' to 'ui/keymaps'
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v2] ui: move 'pc-bios/keymaps' to 'ui/keymaps' |
Date: |
Mon, 13 Jun 2022 13:37:32 +0200 |
On Mon, Jun 13, 2022 at 09:44:56AM +0100, Daniel P. Berrangé wrote:
> The 'keymaps' directory contents is nothing to do with the firmware
> blobs. The 'pc-bios/keymaps' directory appears to have been used
> previously as a convenience for getting the files installed into
> a subdir of the firmware install dir, as well as to make it easier
> to launch QEMU directly from the build tree. These requirements
> do not need to be reflected in the source tree arrangement. The
> keymaps logically belong with the UI code, and meson can install
> them into the right place. For in-tree execution, we merely need
> a suitable symlink from the source tree to the build tree.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>
> Changed in v2:
>
> - Make configure symlink ui/keymaps to $BUILD/pc-bios
> so in-tree build execution works. (Thanks Volker)
Replaced patch, v2 pull req sent.
thanks,
Gerd