Re: [PATCH] target/mips: make SEMIHOSTING conditional on TCG

[Richard Henderson]

On 6/8/22 08:14, Richard Henderson wrote:
> On 6/8/22 03:40, Alex Bennée wrote:
> > Previously SEMIHOSTING was always selected due to requirements in the
> > helper files. Since the original fix there has been refactoring in the
> > mips code to split TCG and KVM code. The recent semihosting
> > refactoring triggers the inverse build problem for KVM only mips
> > builds. Instead of selecting it in the common config make it optional
> > on TCG being enabled in the target Kconfig.
> >
> > Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> > Cc: Richard Henderson<richard.henderson@linaro.org>
> > ---
> >   configs/devices/mips-softmmu/common.mak | 3 ---
> >   target/mips/Kconfig                     | 1 +
> >   2 files changed, 1 insertion(+), 3 deletions(-)

Oh, I would expect all of the settings of SEMIHOSTING to be done this way.  But I guess 
mips is the current target that supports semihosting and kvm-only.


r~