[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 17/35] q35: acpi: drop not needed PCMachineClass::do_not_add_s
From: |
Igor Mammedov |
Subject: |
[PATCH v2 17/35] q35: acpi: drop not needed PCMachineClass::do_not_add_smb_acpi |
Date: |
Wed, 8 Jun 2022 09:53:22 -0400 |
by default we do not version ACPI AML as it's considered
a part of firmware. Drop do_not_add_smb_acpi that blocked
SMBUS AML description on 3.1 and older machine types without
providing justification.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
---
we can keep this bit if anyone can prove/report adverse effect
on VM.
---
include/hw/i386/pc.h | 1 -
hw/i386/acpi-build.c | 2 +-
hw/i386/pc_piix.c | 1 -
hw/i386/pc_q35.c | 1 -
4 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index ffcac5121e..dee38cfac4 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -104,7 +104,6 @@ struct PCMachineClass {
bool rsdp_in_ram;
int legacy_acpi_table_size;
unsigned acpi_data_size;
- bool do_not_add_smb_acpi;
int pci_root_uid;
/* SMBIOS compat: */
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 5b963cca32..d943354999 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1530,7 +1530,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
build_x86_acpi_pci_hotplug(dsdt, pm->pcihp_io_base);
}
build_q35_pci0_int(dsdt);
- if (pcms->smbus && !pcmc->do_not_add_smb_acpi) {
+ if (pcms->smbus) {
build_smb0(dsdt, ICH9_SMB_DEV, ICH9_SMB_FUNC);
}
}
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 578e537b35..7f777f7aed 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -564,7 +564,6 @@ static void pc_i440fx_3_1_machine_options(MachineClass *m)
pc_i440fx_4_0_machine_options(m);
m->is_default = false;
- pcmc->do_not_add_smb_acpi = true;
m->smbus_no_migration_support = true;
m->alias = NULL;
pcmc->pvh_enabled = false;
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 42eb8b9707..f96cbd04e2 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -514,7 +514,6 @@ static void pc_q35_3_1_machine_options(MachineClass *m)
pc_q35_4_0_machine_options(m);
m->default_kernel_irqchip_split = false;
- pcmc->do_not_add_smb_acpi = true;
m->smbus_no_migration_support = true;
m->alias = NULL;
pcmc->pvh_enabled = false;
--
2.31.1
- [PATCH v2 10/35] tests: acpi: q35: add test for smbus-ipmi device, (continued)
- [PATCH v2 10/35] tests: acpi: q35: add test for smbus-ipmi device, Igor Mammedov, 2022/06/08
- [PATCH v2 11/35] tests: acpi: update expected blob DSDT.ipmismbus, Igor Mammedov, 2022/06/08
- [PATCH v2 12/35] tests: acpi: whitelist DSDT.ipmismbus expected blob, Igor Mammedov, 2022/06/08
- [PATCH v2 14/35] tests: acpi: update expected DSDT.ipmismbus blob, Igor Mammedov, 2022/06/08
- [PATCH v2 13/35] ipmi: acpi: use relative path to resource source, Igor Mammedov, 2022/06/08
- [PATCH v2 05/35] acpi: serial-is: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml, Igor Mammedov, 2022/06/08
- [PATCH v2 15/35] acpi: ich9-smb: add support for AcpiDevAmlIf interface, Igor Mammedov, 2022/06/08
- [PATCH v2 16/35] acpi: ipmi: use AcpiDevAmlIf interface to build IPMI device descriptors, Igor Mammedov, 2022/06/08
- [PATCH v2 18/35] tests: acpi: white-list to be re-factored pc/q35 DSDT, Igor Mammedov, 2022/06/08
- [PATCH v2 17/35] q35: acpi: drop not needed PCMachineClass::do_not_add_smb_acpi,
Igor Mammedov <=
- [PATCH v2 06/35] acpi: mc146818rtc: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml, Igor Mammedov, 2022/06/08
- [PATCH v2 19/35] acpi: pc: isa bridge: use AcpiDevAmlIf interface to build ISA device descriptors, Igor Mammedov, 2022/06/08
- [PATCH v2 20/35] acpi: q35: isa bridge: use AcpiDevAmlIf interface to build ISA device descriptors, Igor Mammedov, 2022/06/08
- [PATCH v2 22/35] tests: acpi: add and white-list DSDT.applesmc expected blob, Igor Mammedov, 2022/06/08
- [PATCH v2 23/35] tests: acpi: add applesmc testcase, Igor Mammedov, 2022/06/08
- [PATCH v2 24/35] acpi: applesmc: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML, Igor Mammedov, 2022/06/08
- [PATCH v2 26/35] tests: acpi: white-lists expected DSDT.pvpanic-isa blob, Igor Mammedov, 2022/06/08
- [PATCH v2 27/35] tests: acpi: add pvpanic-isa: testcase, Igor Mammedov, 2022/06/08
- [PATCH v2 21/35] tests: acpi: update expected blobs, Igor Mammedov, 2022/06/08