Re: [PATCH v3 23/49] semihosting: Split out semihost_sys_open

[Richard Henderson]

On 5/23/22 06:30, Peter Maydell wrote:
> > diff --git a/semihosting/guestfd.c b/semihosting/guestfd.c
> > index b6405f5663..7ac2e147a8 100644
> > --- a/semihosting/guestfd.c
> > +++ b/semihosting/guestfd.c
> > @@ -11,6 +11,11 @@
> >   #include "qemu/osdep.h"
> >   #include "exec/gdbstub.h"
> >   #include "semihosting/guestfd.h"
> > +#ifdef CONFIG_USER_ONLY
> > +#include "qemu.h"
> > +#else
> > +#include "semihosting/softmmu-uaccess.h"
> > +#endif
>
> Does this need to be in this patch, or should it be somewhere else?

The first use of target_strlen is added in this patch, so yes, belongs here.


r~