[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] hw/cxl: Make the CXL fixed memory window setup a machine
From: |
Jonathan Cameron |
Subject: |
Re: [PATCH 1/8] hw/cxl: Make the CXL fixed memory window setup a machine parameter. |
Date: |
Tue, 7 Jun 2022 11:02:33 +0100 |
On Mon, 6 Jun 2022 10:24:43 -0700
Ben Widawsky <bwidawsk@kernel.org> wrote:
> On 22-05-31 09:26:27, Paolo Bonzini wrote:
> > On 5/30/22 15:45, Jonathan Cameron via wrote:
> > > + object_property_add(obj, "cxl-fmw", "CXLFixedMemoryWindow",
> > > + machine_get_cfmw, machine_set_cfmw,
> > > + NULL, state);
> > > + object_property_set_description(obj, "cxl-fmw",
> > > + "CXL Fixed Memory Window");
> >
> > Perhaps "CML fixed memory windows (array)" or something like that?
> >
> > Paolo
>
> I had a mail which I apparently never sent. I'd like to see 'fmw' renamed,
> since
> that has no decoder ring in any spec that I'm aware of.
>
> Why not keep cfmws nomenclature? It's well defined.
IIRC s is for structure and this isn't a structure, so I dropped the s.
Expanding cxl makes this a lot more meaningful outside of CXL related
specifications. I preferred the full wording as is currently upstream
but the command lines are insanely long given the new form.
Jonathan
>
> Ben