[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/8] qmp: add filtering of statistics by name
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 7/8] qmp: add filtering of statistics by name |
Date: |
Wed, 27 Apr 2022 18:16:28 +0100 |
User-agent: |
Mutt/2.2.1 (2022-02-19) |
* Paolo Bonzini (pbonzini@redhat.com) wrote:
> On 4/27/22 17:16, Dr. David Alan Gilbert wrote:
> > * Paolo Bonzini (pbonzini@redhat.com) wrote:
> > > On 4/27/22 14:34, Dr. David Alan Gilbert wrote:
> > > > If I specify a 'vm' it's not obvious to me whether I'd get NICs and
> > > > block devices in the future?
> > >
> > > VM would not get those (it's global statistics), but the size could
> > > balloon
> > > if you specify no target at all.
> > >
> > > > Adding a syntax for 'all' into the vcpus list would fix that?
> > >
> > > I don't like having special syntax. The current QAPI just doesn't filter
> > > what is not in the arguments.
> >
> > Is there a object that represents the set of all vcpus?
>
> No.
If it was easy to create one then you could remove all the special
casing of vCPUs/VM target?
(It feels really like you should call a 'stats' method on the target)
> > > Yes, those would have different providers. But a single target can
> > > support
> > > multiple providers.
> >
> > Is that just for different implementations - kvm/hcf/tcg etc or do you
> > envisage multiple providers on an object in a running VM?
>
> I think multiple providers are possible for a single object, for example a
> device could expose both PCI (how many MSIs, etc.) and SCSI (how many
> commands sent/succeeded/failed) statistics.
Yeh fair enough.
Dave
> Paolo
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- Re: [PATCH 1/8] qmp: Support for querying stats, (continued)
- [PATCH 3/8] qmp: add filtering of statistics by target vCPU, Paolo Bonzini, 2022/04/26
- [PATCH 2/8] kvm: Support for querying fd-based stats, Paolo Bonzini, 2022/04/26
- [PATCH 7/8] qmp: add filtering of statistics by name, Paolo Bonzini, 2022/04/26
- Re: [PATCH 7/8] qmp: add filtering of statistics by name, Dr. David Alan Gilbert, 2022/04/27
- Re: [PATCH 7/8] qmp: add filtering of statistics by name, Paolo Bonzini, 2022/04/27
- Re: [PATCH 7/8] qmp: add filtering of statistics by name, Dr. David Alan Gilbert, 2022/04/27
- Re: [PATCH 7/8] qmp: add filtering of statistics by name, Paolo Bonzini, 2022/04/27
- Re: [PATCH 7/8] qmp: add filtering of statistics by name, Dr. David Alan Gilbert, 2022/04/27
- Re: [PATCH 7/8] qmp: add filtering of statistics by name, Paolo Bonzini, 2022/04/27
- Re: [PATCH 7/8] qmp: add filtering of statistics by name,
Dr. David Alan Gilbert <=
- Re: [PATCH 7/8] qmp: add filtering of statistics by name, Paolo Bonzini, 2022/04/28
[PATCH 5/8] qmp: add filtering of statistics by provider, Paolo Bonzini, 2022/04/26
[PATCH 4/8] hmp: add basic "info stats" implementation, Paolo Bonzini, 2022/04/26
[PATCH 8/8] hmp: add filtering of statistics by name, Paolo Bonzini, 2022/04/26
[PATCH 6/8] hmp: add filtering of statistics by provider, Paolo Bonzini, 2022/04/26