Re: [PATCH] Warn user if the vga flag is passed but no vga device is created

[Peter Maydell]

On Tue, 12 Apr 2022 at 13:13, Thomas Huth <thuth@redhat.com> wrote:
> On 08/04/2022 12.45, Gautam Agrawal wrote:
> > +    if (!vga_interface_created && !default_vga) {
> > +        warn_report("No vga device is created");
>
> I'm not a native speaker, and maybe it's just a matter of taste, but I'd
> rather say it in past tense: "No VGA device has been created"

I think we could phrase the warning to tell the user more
clearly what has happened:

"A -vga option was passed but this machine type does not use that
option; no VGA device has been created"

thanks
-- PMM