Re: [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event

[Markus Armbruster]

Victor Toso <victortoso@redhat.com> writes:

> Example output lacks mandatory member @timestamp.  Provide it.
>
> Event's documentation is not properly formatted. Fix it by:
> - Adding @ to "device-id"
> - Adding extra line for "Since" section
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
>  qapi/net.json | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/net.json b/qapi/net.json
> index 7fab2e7cd8..0d4578bd07 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -685,13 +685,15 @@
>  # Failover primary devices which were hidden (not hotplugged when requested)
>  # before will now be hotplugged by the virtio-net standby device.
>  #
> -# device-id: QEMU device id of the unplugged device
> +# @device-id: QEMU device id of the unplugged device
> +#
>  # Since: 4.2
>  #
>  # Example:
>  #
>  # <- { "event": "FAILOVER_NEGOTIATED",
> -#      "data": "net1" }
> +#      "data": { "device-id": "net1" },
> +#      "timestamp": { "seconds": 1368697518, "microseconds": 326866 } }
>  #
>  ##
>  { 'event': 'FAILOVER_NEGOTIATED',

Reviewed-by: Markus Armbruster <armbru@redhat.com>