qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] tests: Do not treat the iotests as separate meson test ta


From: Hanna Reitz
Subject: Re: [PATCH v4] tests: Do not treat the iotests as separate meson test target anymore
Date: Fri, 18 Mar 2022 18:04:19 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 10.03.22 08:50, Thomas Huth wrote:
If there is a failing iotest, the output is currently not logged to
the console anymore. To get this working again, we need to run the
meson test runner with "--print-errorlogs" (and without "--verbose"
due to a current meson bug that will be fixed here:
https://github.com/mesonbuild/meson/commit/c3f145ca2b9f5.patch ).
We could update the "meson test" call in tests/Makefile.include,
but actually it's nicer and easier if we simply do not treat the
iotests as separate test target anymore and integrate them along
with the other test suites. This has the disadvantage of not getting
the detailed progress indication there anymore, but since that was
only working right in single-threaded "make -j1" mode anyway, it's
not a huge loss right now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  v4: updated commit description

  meson.build            | 6 +++---
  scripts/mtest2make.py  | 4 ----
  tests/Makefile.include | 9 +--------
  3 files changed, 4 insertions(+), 15 deletions(-)

I can’t really say I understand what’s going on in this patch and around it, but I can confirm that it before this patch, fail diffs aren’t printed; but afterwards, they are.  So I’m afraid all I can give is a

Tested-by: Hanna Reitz <hreitz@redhat.com>

If noone else steps up and you need a tree for this to go in, I’d be up for it.

Hanna




reply via email to

[Prev in Thread] Current Thread [Next in Thread]