[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v20 2/7] net/vmnet: add vmnet backends to qapi/net
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v20 2/7] net/vmnet: add vmnet backends to qapi/net |
Date: |
Thu, 17 Mar 2022 11:00:50 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Vladislav Yaroshchuk <vladislav.yaroshchuk@jetbrains.com> writes:
> On Wed, Mar 16, 2022 at 4:58 PM Markus Armbruster <armbru@redhat.com> wrote:
>
>> Vladislav Yaroshchuk <vladislav.yaroshchuk@jetbrains.com> writes:
>>
>> > Create separate netdevs for each vmnet operating mode:
>> > - vmnet-host
>> > - vmnet-shared
>> > - vmnet-bridged
>> >
>> > Signed-off-by: Vladislav Yaroshchuk <Vladislav.Yaroshchuk@jetbrains.com>
>>
>> Any QAPI schema changes since v15? I'm asking because I acked v8, v13,
>> and v15, but each time you neglected to carry my Acked-by lines in later
>> revisions.
>>
>>
> QAPI is not changed, but the "Since" statement was updated
> for new netdevs (7.0 -> 7.1). That's the reason why I dropped
> your Acked-by. I've also mentioned this in cover letter:
You mean I'm supposed to read the cover letter?!? (I am).
> v15 -> v16
> [...]
> - QAPI: change version to 7.1 (cause 7.0 feature freeze
> happened). This is the only change in QAPI, Markus Armbruster,
> please confirm if you can (decided to drop your Acked-by due
> to this change)
Clerical change, keeping my Acked-by would've been fine.
> [...]
QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>
Thanks!
- [PATCH v20 0/7] Add vmnet.framework based network backend, Vladislav Yaroshchuk, 2022/03/15
- [PATCH v20 3/7] net/vmnet: implement shared mode (vmnet-shared), Vladislav Yaroshchuk, 2022/03/15
- [PATCH v20 4/7] net/vmnet: implement host mode (vmnet-host), Vladislav Yaroshchuk, 2022/03/15
- [PATCH v20 5/7] net/vmnet: implement bridged mode (vmnet-bridged), Vladislav Yaroshchuk, 2022/03/15
- [PATCH v20 6/7] net/vmnet: update qemu-options.hx, Vladislav Yaroshchuk, 2022/03/15
- [PATCH v20 7/7] net/vmnet: update hmp-commands.hx, Vladislav Yaroshchuk, 2022/03/15