|
From: | Richard Henderson |
Subject: | Re: [PATCH v2 9/9] dump: Consolidate elf note function |
Date: | Fri, 11 Mar 2022 11:54:25 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 |
On 3/10/22 03:08, Janosch Frank wrote:
+static void write_elf_notes(DumpState *s, Error **errp) +{ + ERRP_GUARD(); + + if (dump_is_64bit(s)) { + write_elf64_notes(fd_write_vmcore, s, errp); + } else { + write_elf32_notes(fd_write_vmcore, s, errp); + } + if (*errp) { + return; + } +}
Are you anticipating adding more code to this function? Otherwise the early return, and the guard are useless. r~
[Prev in Thread] | Current Thread | [Next in Thread] |