Re: [PATCH v3 12/12] ui/console: call gfx_switch() even if the current scanout is GL

[Akihiko Odaki]

On 2022/03/09 17:33, Marc-André Lureau wrote:
> Hi
>
> On Wed, Mar 9, 2022 at 12:21 PM Akihiko Odaki <akihiko.odaki@gmail.com 
> <mailto:akihiko.odaki@gmail.com>> wrote:
>
>
>     If it is expected that dpy_gfx_update is required, it should call
>     dpy_gfx_update. I agree it is not a right timing to fix vnc to remove
>     the implicit update as it is pre-existing.
>     However the lack of dpy_gfx_update call is a regression and should
>     be fixed.
>
>
> Calling dpy_gfx_update is done when the scanount.kind is SURFACE.
>
> dpy_gfx_update is specific to SURFACE, GL uses dpy_gl_update.
>
> --
> Marc-André Lureau

egl-headless requires non-OpenGL to display the surface content even if 
scanout.kind is not SURFACE. Calling dpy_gfx_update is done when the 
scanount.kind is SURFACE is not enough.

Regards,
Akihiko Odaki