Re: [PATCH v6 02/14] target/riscv: rvk: add support for zbkb extension

[Weiwei Li]

Thanks for your comments.

在 2022/2/28 上午2:47, Richard Henderson 写道:
> On 2/27/22 04:25, Weiwei Li wrote:
> > +static void gen_packh(TCGv ret, TCGv src1, TCGv src2)
> > +{
> > +    TCGv t = tcg_temp_new();
> > +
> > +    tcg_gen_ext8u_tl(t, src2);
> > +    tcg_gen_deposit_tl(ret, src1, t, 8, TARGET_LONG_BITS - 8);
> > +    tcg_temp_free(t);
> > +}
> > +
> > +static void gen_packw(TCGv ret, TCGv src1, TCGv src2)
> > +{
> > +    TCGv t = tcg_temp_new();
> > +
> > +    tcg_gen_ext16s_tl(t, src2);
> > +    tcg_gen_deposit_tl(ret, src1, t, 16, 48);
> > +    tcg_temp_free(t);
> > +}
>
> Missing TARGET_LONG_BITS here; would break on RV32.
packw is RV64-only instruction. Is it necessary to use TARGET_LONG_BITS 
here?
> > +static bool trans_brev8(DisasContext *ctx, arg_brev8 *a)
> > +{
> > +    REQUIRE_ZBKB(ctx);
> > +
> > +    TCGv dest = dest_gpr(ctx, a->rd);
> > +    TCGv src1 = get_gpr(ctx, a->rs1, EXT_NONE);
> > +
> > +    gen_helper_brev8(dest, src1);
> > +    gen_set_gpr(ctx, a->rd, dest);
> > +
> > +    return true;
> > +}
> ...
> > +static bool trans_unzip(DisasContext *ctx, arg_unzip *a)
> > +{
> > +    REQUIRE_ZBKB(ctx);
> > +    REQUIRE_32BIT(ctx);
> > +
> > +    TCGv dest = dest_gpr(ctx, a->rd);
> > +    TCGv src1 = get_gpr(ctx, a->rs1, EXT_NONE);
> > +
> > +    gen_helper_unzip(dest, src1);
> > +    gen_set_gpr(ctx, a->rd, dest);
> > +
> > +    return true;
> > +}
> > +
> > +static bool trans_zip(DisasContext *ctx, arg_zip *a)
> > +{
> > +    REQUIRE_ZBKB(ctx);
> > +    REQUIRE_32BIT(ctx);
> > +
> > +    TCGv dest = dest_gpr(ctx, a->rd);
> > +    TCGv src1 = get_gpr(ctx, a->rs1, EXT_NONE);
> > +
> > +    gen_helper_zip(dest, src1);
> > +    gen_set_gpr(ctx, a->rd, dest);
> > +
> > +    return true;
> > +}
>
> Use gen_unary.

OK. I'll fix it.

Regards,

Weiwei Li

> r~