qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 00/12] GL & D-Bus display related fixes


From: marcandre . lureau
Subject: [PATCH v2 00/12] GL & D-Bus display related fixes
Date: Thu, 17 Feb 2022 15:58:17 +0400

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

In the thread "[PATCH 0/6] ui/dbus: Share one listener for a console", Akihiko
Odaki reported a number of issues with the GL and D-Bus display. His series
propose a different design, and reverting some of my previous generic console
changes to fix those issues.

However, as I work through the issue so far, they can be solved by reasonable
simple fixes while keeping the console changes generic (not specific to the
D-Bus display backend). I belive a shared infrastructure is more beneficial long
term than having GL-specific code in the DBus code (in particular, the
egl-headless & VNC combination could potentially use it)

Thanks a lot Akihiko for reporting the issues proposing a different approach!
Please test this alternative series and let me know of any further issues. My
understanding is that you are mainly concerned with the Cocoa backend, and I
don't have a way to test it, so please check it. If necessary, we may well have
to revert my earlier changes and go your way, eventually.

Marc-André Lureau (12):
  ui/console: fix crash when using gl context with non-gl listeners
  ui/console: fix texture leak when calling surface_gl_create_texture()
  ui: do not create a surface when resizing a GL scanout
  ui/console: move check for compatible GL context
  ui/console: move dcl compatiblity check to a callback
  ui/console: egl-headless is compatible with non-gl listeners
  ui/dbus: associate the DBusDisplayConsole listener with the given
    console
  ui/console: move console compatibility check to dcl_display_console()
  ui/shader: fix potential leak of shader on error
  ui/shader: free associated programs
  ui/console: add a dpy_gfx_switch callback helper
  ui/dbus: fix texture sharing

 include/ui/console.h |  19 ++++---
 ui/dbus.h            |   3 ++
 ui/console-gl.c      |   4 ++
 ui/console.c         | 119 ++++++++++++++++++++++++++-----------------
 ui/dbus-console.c    |  27 +++++-----
 ui/dbus-listener.c   |  11 ----
 ui/dbus.c            |  33 +++++++++++-
 ui/egl-headless.c    |  17 ++++++-
 ui/gtk.c             |  18 ++++++-
 ui/sdl2.c            |   9 +++-
 ui/shader.c          |   9 +++-
 ui/spice-display.c   |   9 +++-
 12 files changed, 192 insertions(+), 86 deletions(-)

-- 
2.34.1.428.gdcc0cd074f0c





reply via email to

[Prev in Thread] Current Thread [Next in Thread]