[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/6] target/arm: Fix '-cpu max' for HVF
From: |
Peter Maydell |
Subject: |
[PATCH 5/6] target/arm: Fix '-cpu max' for HVF |
Date: |
Fri, 4 Feb 2022 16:55:05 +0000 |
Currently when using hvf we mishandle '-cpu max': we fall through to
the TCG version of its initfn, which then sets a lot of feature bits
that the real host CPU doesn't have. The hvf accelerator code then
exposes these bogus ID register values to the guest because it
doesn't check that the host really has the features.
Make '-cpu host' be like '-cpu max' for hvf, as we do with kvm.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target/arm/cpu64.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index bc25a2567bf..fd611c97116 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -29,6 +29,7 @@
#include "hw/loader.h"
#endif
#include "sysemu/kvm.h"
+#include "sysemu/hvf.h"
#include "kvm_arm.h"
#include "hvf_arm.h"
#include "qapi/visitor.h"
@@ -710,8 +711,8 @@ static void aarch64_max_initfn(Object *obj)
uint64_t t;
uint32_t u;
- if (kvm_enabled()) {
- /* With KVM, '-cpu max' is identical to '-cpu host' */
+ if (kvm_enabled() || hvf_enabled()) {
+ /* With KVM or HVF, '-cpu max' is identical to '-cpu host' */
aarch64_host_initfn(obj);
return;
}
--
2.25.1
- [PATCH 0/6] target/arm: -cpu host/max KVM and HVF fixes, Peter Maydell, 2022/02/04
- [PATCH 4/6] target/arm: Unindent unnecessary else-clause, Peter Maydell, 2022/02/04
- [PATCH 2/6] target/arm: Use aarch64_cpu_register() for 'host' CPU type, Peter Maydell, 2022/02/04
- [PATCH 1/6] target/arm: Move '-cpu host' code to cpu64.c, Peter Maydell, 2022/02/04
- [PATCH 6/6] target/arm: Support PAuth extension for hvf, Peter Maydell, 2022/02/04
- [PATCH 5/6] target/arm: Fix '-cpu max' for HVF,
Peter Maydell <=
- [PATCH 3/6] target/arm: Make KVM -cpu max exactly like -cpu host, Peter Maydell, 2022/02/04
- Re: [PATCH 0/6] target/arm: -cpu host/max KVM and HVF fixes, Philippe Mathieu-Daudé, 2022/02/06
- Re: [PATCH 0/6] target/arm: -cpu host/max KVM and HVF fixes, Andrew Jones, 2022/02/09
- Re: [PATCH 0/6] target/arm: -cpu host/max KVM and HVF fixes, Alexander Graf, 2022/02/09