qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN


From: Richard Henderson
Subject: Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN
Date: Fri, 24 Dec 2021 17:50:44 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 12/20/21 2:31 PM, Philippe Mathieu-Daudé wrote:
+    /* Used for user-only emulation of prctl(PR_SET_UNALIGN). */
+    bool prctl_unalign_sigbus;

Could we forward-declare a UserEmuCPUState structure in this file,
use it here:

        struct UserEmuCPUState *user_cpu;

and declare it in include/hw/core/useremu-cpu.h (or better name)
restricted to user emulation?

Eh.  I suppose we could, but at the moment it's one byte in an existing padding 
hole.

I'd rather not mix sys/user emu specific fields in CPUState.

There are *lots* of system specific fields in CPUState.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]