Re: [PATCH v2] audio: Add sndio backend

[Christian Schoenebeck]

On Montag, 20. Dezember 2021 16:41:31 CET Christian Schoenebeck wrote:
> On Freitag, 17. Dezember 2021 10:38:32 CET Alexandre Ratchov wrote:
> > sndio is the native API used by OpenBSD, although it has been ported to
> > other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
> > 
> > Signed-off-by: Brad Smith <brad@comstyle.com>
> > Signed-off-by: Alexandre Ratchov <alex@caoua.org>
> > ---
> > 
> > Thank you for the reviews and all the comments. Here's a second diff
> > with all the suggested changes:
> > 
> > - Replace ISC license by SPDX-License-Identifier header
> > - Fix units (milli- vs micro-) in comment about SNDIO_LATENCY_US
> > - Drop outdated comment about the "size" argument of
> > sndio_get_buffer_out()
> > - Fix AUDIO_FORMAT_U32 handling (missing "break" statement)
> > - Set {read,write] methods to audio_generic_{read,write} (fixes craches)
> > - Check if backend is enabled in sndio_poll_event()
> > - Use https://sndio.org in description
> > - Mark options as available after 7.0 release (instead of 6.2)
> > - Describe sndio-specific options (dev, latency) in qemu-options.hx
> > - Add myself as reviewer to MAINTAINERS
> > - Style fixes: no space after function names, use 4-space indent
> > - Don't use "return foo()" if foo() returns void
> > - Include backend to audio_drivers_priority[]
> > 
> > Tested on OpenBSD, works as expected!
> > 
> >  MAINTAINERS            |   5 +
> >  audio/audio.c          |   1 +
> >  audio/audio_template.h |   2 +
> >  audio/meson.build      |   1 +
> >  audio/sndioaudio.c     | 555 +++++++++++++++++++++++++++++++++++++++++
> >  meson.build            |   9 +-
> >  meson_options.txt      |   4 +-
> >  qapi/audio.json        |  25 +-
> >  qemu-options.hx        |  16 ++
> >  tests/vm/freebsd       |   3 +
> >  10 files changed, 618 insertions(+), 3 deletions(-)
> >  create mode 100644 audio/sndioaudio.c
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 7543eb4d59..76bdad064f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2307,6 +2307,7 @@ X: audio/jackaudio.c
> > 
> >  X: audio/ossaudio.c
> >  X: audio/paaudio.c
> >  X: audio/sdlaudio.c
> > 
> > +X: audio/sndio.c
> > 
> >  X: audio/spiceaudio.c
> >  F: qapi/audio.json
> > 
> > @@ -2349,6 +2350,10 @@ R: Thomas Huth <huth@tuxfamily.org>
> > 
> >  S: Odd Fixes
> >  F: audio/sdlaudio.c
> > 
> > +Sndio Audio backend
> > +R: Alexandre Ratchov <alex@caoua.org>
> > +F: audio/sndio.c
> > +
> 
> Thanks Alexandre for volunteering as reviewer!
> 
> Gerd, would it be OK to set you as maintainer for now until new
> maintainer(s) adopt audio sections? Or should this start with "S: Orphan"
> instead?

Alexandre, if Gerd does not reply in a week or so, then please add "S: Orphan" 
to MAINTAINERS for now to make it clear that there is no maintainer for sndio 
yet to increase the chance for somebody to adopt it.

>From Volker's response I assume you will be posting a v3 anyway.

If nobody takes care to queue your patch then let me know. Maybe I can push it 
through my queue this time, provided that there are enough reviews. I also saw 
your patch just by coincidence BTW, so please CC maintainers of affected files 
as suggested by Volker.

Best regards,
Christian Schoenebeck