Re: [PATCH] vl: Add -set options to device opts dict when using JSON syntax for -device

[Gerd Hoffmann]

  Hi,

> > Simliar: configure stuff not supported by libvirt:
> > 
> >    <qemu:commandline>
> >      <qemu:arg value='-set'/>
> >      <qemu:arg value='device.video0.guestdebug=1'/>
> >    </qemu:commandline>
> > 
> > There will always be a gap between qemu and libvirt, even if most of
> > them are temporary only (while developing a new feature).  I think we
> > need some way to deal with this kind of tweaks when moving to QAPI-based
> > machine setup.  Possibly not in qemu, maybe it's easier to add new
> > '<qemu:set device=... property=... value=...>' syntax to libvirt.

> Can the set feature be handled by libvirt ?
> I mean, libvirt could do the merge itself because if I understand it
> correctly, the snippset just say:
> please add/override the "guestdebug=1" key/value pair to the 'video0' device
> command option.

Yes.  The above is the same as

        -device qxl,id=video0,${more-libvirt-opts},guestdebug=1

take care,
  Gerd