|
From: | Richard Henderson |
Subject: | Re: [PATCH] tests/qtest/virtio-net-failover: Use g_random_int() instead of g_test_rand_int() |
Date: | Mon, 20 Dec 2021 11:26:54 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 |
On 12/20/21 2:27 AM, Thomas Huth wrote:
const gchar *tmpdir = g_get_tmp_dir(); gchar *tmpfile = g_strdup_printf("%s/failover_test_migrate-%u-%u", - tmpdir, getpid(), g_test_rand_int()); + tmpdir, getpid(), g_random_int());
Random numbers plus pid are irrelevant, because you still don't have guaranteed uniqueness -- think stale files in /tmp.
Use g_file_open_tmp. r~
[Prev in Thread] | Current Thread | [Next in Thread] |