Re: [PATCH v2] linux-user: Mark cpu_loop() with noreturn attribute

[Laurent Vivier]

Le 15/12/2021 à 11:55, Philippe Mathieu-Daudé a écrit :
> Ping? (patch reviewed)
>
> On 11/6/21 12:39, Philippe Mathieu-Daudé wrote:
> > cpu_loop() never exits, so mark it with QEMU_NORETURN.
> >
> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> > Reviewed-By: Warner Losh <imp@bsdimp.com>
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> > v2:
> > - rebased
> > - restricted to linux-user
> >
> > Supersedes: <20210905000429.1097336-1-f4bug@amsat.org>
> > ---
> >   linux-user/user-internals.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/linux-user/user-internals.h b/linux-user/user-internals.h
> > index 661612a088b..c7ad00268af 100644
> > --- a/linux-user/user-internals.h
> > +++ b/linux-user/user-internals.h
> > @@ -65,7 +65,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
> >                       abi_long arg5, abi_long arg6, abi_long arg7,
> >                       abi_long arg8);
> >   extern __thread CPUState *thread_cpu;
> > -void cpu_loop(CPUArchState *env);
> > +void QEMU_NORETURN cpu_loop(CPUArchState *env);
> >   const char *target_strerror(int err);
> >   int get_osversion(void);
> >   void init_qemu_uname_release(void);

Applied to my linux-user-for-7.0 branch.

Thanks,
Laurent