Re: [PATCH v2] block: drop BLK_PERM_GRAPH_MOD

[Vladimir Sementsov-Ogievskiy]

Ping)

03.09.2021 21:47, Eric Blake wrote:
> On Thu, Sep 02, 2021 at 12:37:54PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > First, this permission never protected a node from being changed, as
> > generic child-replacing functions don't check it.
> >
> > Second, it's a strange thing: it presents a permission of parent node

[..]

> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index 06674c25c9..6fa2c4ab82 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -1825,14 +1825,11 @@
> >   #
> >   # @resize: This permission is required to change the size of a block node.
> >   #
> > -# @graph-mod: This permission is required to change the node that this
> > -#             BdrvChild points to.
> > -#
>
> Do we need to mention that graph-mod was removed in 6.2?

This structure is used only for debugging purposes, I don't think it worth 
mentioning.

> >   # Since: 4.0
> >   ##
> >   { 'enum': 'BlockPermission',
> > -  'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize',
> > -            'graph-mod' ] }
> > +  'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize' ] }
> > +
> >   ##
> >   # @XDbgBlockGraphEdge:
> >   #
>
> Otherwise the patch makes sense to me, but I'd rather that Kevin chime in.


--
Best regards,
Vladimir