Re: [PATCH 07/10] configure: unify x86_64 and x32

[Richard Henderson]

On 12/16/21 7:30 AM, Paolo Bonzini wrote:
> On 12/16/21 10:10, Philippe Mathieu-Daudé wrote:
> > On 12/16/21 09:51, Paolo Bonzini wrote:
> > > The only difference between the two, as far as either configure or
> > > Meson are concerned, is in the multilib flags passed to the compiler.
> > >
> > > For QEMU, this fixes the handling of TYPE_OLDDEVT in
> > > include/exec/user/thunk.h and enables testing of dirty ring buffer,
> > > because both are using HOST_X86_64.
> > >
> > > For tests/tcg, this means that on a hypothetical x32 host the
> > > cross compiler will not be used to build the tests.
> >
> > Why not add the cross compiler definitions to tests/tcg?
> >
> > +: ${cross_cc_x32="$cross_cc_x86_64"}
> > +: ${cross_cc_cflags_x32="-mx32"}
>
> tests/tcg does not support building x32 tests right now, does it?

We don't have docker support for x32, if that's what you mean.  But if you have x32 
libraries installed on your host, I would think it would work.


> What I meant is that, if you're on an x32 host, tests/tcg will now build i386 
> and
> x86-64 tests with the native compiler.
And of course, those multilibs must be installed as well.


r~