qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/10] configure: simplify creation of plugin symbol list


From: Richard Henderson
Subject: Re: [PATCH 01/10] configure: simplify creation of plugin symbol list
Date: Fri, 17 Dec 2021 12:42:06 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 12/16/21 12:51 AM, Paolo Bonzini wrote:
--dynamic-list is present on all supported ELF (not Windows or Darwin)
platforms, since it dates back to 2006; -exported_symbols_list is
likewise present on all supported versions of macOS.  Do not bother
doing a functional test in configure.

Since stuff is being moved to meson, move the creation of the
Darwin-formatted symbols list there, reducing the transform to a single
sed command.  This also requires using -Xlinker instead of -Wl, in order
to support weird paths that include a comma.

Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
---
  configure           | 16 ----------------
  plugins/meson.build | 13 +++++++++----
  2 files changed, 9 insertions(+), 20 deletions(-)

Surely you'd want to be removing all of the ld_dynamic_list and ld_exported_symbols_list code as well?


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]