[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 9/9] checkpatch: Do not allow deprecated g_memdup()
From: |
Laurent Vivier |
Subject: |
[PULL 9/9] checkpatch: Do not allow deprecated g_memdup() |
Date: |
Fri, 17 Dec 2021 21:10:19 +0100 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
g_memdup() is insecure and as been deprecated in GLib 2.68.
QEMU provides the safely equivalent g_memdup2() wrapper.
Do not allow more g_memdup() calls in the repository, provide
a hint to use g_memdup2().
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20210903174510.751630-29-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
scripts/checkpatch.pl | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index cb8eff233e06..5caa739db486 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2850,6 +2850,11 @@ sub process {
WARN("consider using g_path_get_$1() in preference to
g_strdup($1())\n" . $herecurr);
}
+# enforce g_memdup2() over g_memdup()
+ if ($line =~ /\bg_memdup\s*\(/) {
+ ERROR("use g_memdup2() instead of unsafe g_memdup()\n"
. $herecurr);
+ }
+
# recommend qemu_strto* over strto* for numeric conversions
if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
ERROR("consider using qemu_$1 in preference to $1\n" .
$herecurr);
--
2.33.1
- [PULL 0/9] Trivial branch for 7.0 patches, Laurent Vivier, 2021/12/17
- [PULL 2/9] target/i386/kvm: Replace use of __u32 type, Laurent Vivier, 2021/12/17
- [PULL 3/9] qemu-keymap: Add license in generated files, Laurent Vivier, 2021/12/17
- [PULL 1/9] configure: Symlink binaries using .exe suffix with MinGW, Laurent Vivier, 2021/12/17
- [PULL 7/9] glib-compat: Introduce g_memdup2() wrapper, Laurent Vivier, 2021/12/17
- [PULL 5/9] hw/virtio/vhost: Fix typo in comment., Laurent Vivier, 2021/12/17
- [PULL 9/9] checkpatch: Do not allow deprecated g_memdup(),
Laurent Vivier <=
- [PULL 8/9] tests/qtest: Replace g_memdup() by g_memdup2(), Laurent Vivier, 2021/12/17
- [PULL 6/9] docs/block-replication.txt: Fix replication top-id command demo, Laurent Vivier, 2021/12/17
- [PULL 4/9] hw/avr: Realize AVRCPU qdev object using qdev_realize(), Laurent Vivier, 2021/12/17
- Re: [PULL 0/9] Trivial branch for 7.0 patches, Richard Henderson, 2021/12/17