Re: [PATCH v2 25/37] build-sys: set glib dependency version

[Philippe Mathieu-Daudé]

On 12/17/21 14:40, Marc-André Lureau wrote:

>     > diff --git a/meson.build b/meson.build
>     > index e1cddf5139..9494590aa2 100644
>     > --- a/meson.build
>     > +++ b/meson.build
>     > @@ -311,14 +311,16 @@ endif
>     >  add_project_arguments(config_host['GLIB_CFLAGS'].split(),
>     >                        native: false, language: ['c', 'cpp', 'objc'])
>     >  glib = declare_dependency(compile_args:
>     config_host['GLIB_CFLAGS'].split(),
>     > -                          link_args:
>     config_host['GLIB_LIBS'].split())
>     > +                          link_args:
>     config_host['GLIB_LIBS'].split(),
>     > +                          version: config_host['GLIB_VERSION'])
>     >  # override glib dep with the configure results (for subprojects)
>     >  meson.override_dependency('glib-2.0', glib)
>     > 
>     >  gio = not_found
>     >  if 'CONFIG_GIO' in config_host
>     >    gio = declare_dependency(compile_args:
>     config_host['GIO_CFLAGS'].split(),
>     > -                           link_args:
>     config_host['GIO_LIBS'].split())
>     > +                           link_args:
>     config_host['GIO_LIBS'].split(),
>     > +                           version: config_host['GLIB_VERSION'])
>     >  endif
>     >  lttng = not_found
>     >  if 'CONFIG_TRACE_UST' in config_host
>     >
> 
>     Can you display it in summary_info too?
> 
> 
> Yeah, although it would need a special treatment.
> 
> Since GLib is a mandatory dependency, I am not sure we want to show
>     GLib                         : YES
> 
> And because it's not a pkg-config dep, it doesn't show the version
> (could probably be fixed in meson).

Ah OK. Yes, I was thinking about displaying the GLib version.

> If you don't mind,  I leave that for another day :)

Sounds good, thanks.