[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC qemu.qmp PATCH 12/24] GitLab CI: Add check-dco script
From: |
John Snow |
Subject: |
[RFC qemu.qmp PATCH 12/24] GitLab CI: Add check-dco script |
Date: |
Wed, 15 Dec 2021 16:06:22 -0500 |
Borrowed with minor modifications from qemu.git.
Signed-off-by: John Snow <jsnow@redhat.com>
---
.gitlab-ci.d/check-dco.py | 98 +++++++++++++++++++++++++++++++++++++++
.gitlab-ci.d/index.yml | 2 +
.gitlab-ci.d/test.yml | 15 ++++++
3 files changed, 115 insertions(+)
create mode 100755 .gitlab-ci.d/check-dco.py
create mode 100644 .gitlab-ci.d/test.yml
diff --git a/.gitlab-ci.d/check-dco.py b/.gitlab-ci.d/check-dco.py
new file mode 100755
index 0000000..747cd54
--- /dev/null
+++ b/.gitlab-ci.d/check-dco.py
@@ -0,0 +1,98 @@
+#!/usr/bin/env python3
+#
+# check-dco.py: validate all commits are signed off
+#
+# Copyright (C) 2020 Red Hat, Inc.
+#
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+import argparse
+import os
+import os.path
+import sys
+import subprocess
+
+parser = argparse.ArgumentParser("check-dco")
+parser.add_argument(
+ "repourl",
+ help="upstream repo URL"
+)
+parser.add_argument(
+ "refspec",
+ help="upstream's default branch (or other refspec)"
+)
+args = parser.parse_args()
+
+
+subprocess.check_call(["git", "remote", "add", "check-dco", args.repourl])
+subprocess.check_call(["git", "fetch", "check-dco", args.refspec],
+ stdout=subprocess.DEVNULL,
+ stderr=subprocess.DEVNULL)
+
+ancestor = subprocess.check_output(
+ ["git", "merge-base", f"check-dco/{args.refspec}", "HEAD"],
+ universal_newlines=True)
+ancestor = ancestor.strip()
+
+subprocess.check_call(["git", "remote", "rm", "check-dco"])
+
+errors = False
+
+print("\nChecking for 'Signed-off-by: NAME <EMAIL>' " +
+ "on all commits since %s...\n" % ancestor)
+
+log = subprocess.check_output(["git", "log", "--format=%H %s",
+ ancestor + "..."],
+ universal_newlines=True)
+
+if log == "":
+ commits = []
+else:
+ commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")]
+
+for sha, subject in commits:
+
+ msg = subprocess.check_output(["git", "show", "-s", sha],
+ universal_newlines=True)
+ lines = msg.strip().split("\n")
+
+ print("🔍 %s %s" % (sha, subject))
+ sob = False
+ for line in lines:
+ if "Signed-off-by:" in line:
+ sob = True
+ if "localhost" in line:
+ print(" ❌ FAIL: bad email in %s" % line)
+ errors = True
+
+ if not sob:
+ print(" ❌ FAIL missing Signed-off-by tag")
+ errors = True
+
+if errors:
+ print("""
+
+❌ ERROR: One or more commits are missing a valid Signed-off-By tag.
+
+
+This project requires all contributors to assert that their contributions
+are provided in compliance with the terms of the Developer's Certificate
+of Origin 1.1 (DCO):
+
+ https://developercertificate.org/
+
+To indicate acceptance of the DCO every commit must have a tag
+
+ Signed-off-by: REAL NAME <EMAIL>
+
+This can be achieved by passing the "-s" flag to the "git commit" command.
+
+To bulk update all commits on current branch "git rebase" can be used:
+
+ git rebase -i master -x 'git commit --amend --no-edit -s'
+
+""")
+
+ sys.exit(1)
+
+sys.exit(0)
diff --git a/.gitlab-ci.d/index.yml b/.gitlab-ci.d/index.yml
index cf61dec..cd6a65e 100644
--- a/.gitlab-ci.d/index.yml
+++ b/.gitlab-ci.d/index.yml
@@ -4,7 +4,9 @@
stages:
- containers
- build
+ - test
include:
- local: '/.gitlab-ci.d/containers.yml'
- local: '/.gitlab-ci.d/build.yml'
+ - local: '/.gitlab-ci.d/test.yml'
diff --git a/.gitlab-ci.d/test.yml b/.gitlab-ci.d/test.yml
new file mode 100644
index 0000000..35fa105
--- /dev/null
+++ b/.gitlab-ci.d/test.yml
@@ -0,0 +1,15 @@
+check-dco:
+ stage: test
+ image: $CI_REGISTRY_IMAGE/python:latest
+ needs:
+ job: python-container
+ script:
+ - .gitlab-ci.d/check-dco.py
+ "https://gitlab.com/jsnow/qemu.qmp.git"
+ "main"
+ variables:
+ GIT_DEPTH: 1000
+ rules:
+ - if: '$CI_PROJECT_NAMESPACE == "jsnow" && $CI_COMMIT_BRANCH ==
$CI_DEFAULT_BRANCH'
+ when: never
+ - when: on_success
--
2.31.1
- Re: [RFC qemu.qmp PATCH 03/24] Update maintainer metadata, (continued)
- [RFC qemu.qmp PATCH 02/24] Update VERSION to 0.0.0a1, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 04/24] Update project description, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 05/24] Update project URLs, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 10/24] Add build and test container to gitlab CI configuration, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 06/24] Move README.rst to INDEX.rst and update, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 09/24] Remove sub-dependency pins from Pipfile, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 07/24] Move PACKAGE.rst to README.rst and update, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 08/24] Update Pipfile.lock, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 11/24] Add package build step to GitLab CI, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 12/24] GitLab CI: Add check-dco script,
John Snow <=
- [RFC qemu.qmp PATCH 13/24] GitLab CI: Add pipenv and tox tests, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 14/24] GitLab CI: Add avocado junit XML output to tests, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 15/24] GitLab CI: Publish python packages to GitLab package repo, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 17/24] Makefile: add build and publish targets, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 19/24] python: configure sphinx, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 20/24] python: adjust apidoc stubs, John Snow, 2021/12/15
- [RFC qemu.qmp PATCH 18/24] add Sphinx documentation config stub, John Snow, 2021/12/15