[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 01/18] ui: avoid compiler warnings from unused clipboard info
From: |
Daniel P . Berrangé |
Subject: |
[PATCH v5 01/18] ui: avoid compiler warnings from unused clipboard info variable |
Date: |
Wed, 15 Dec 2021 14:19:32 +0000 |
With latest clang 13.0.0 we get
../ui/clipboard.c:47:34: error: variable 'old' set but not used
[-Werror,-Wunused-but-set-variable]
g_autoptr(QemuClipboardInfo) old = NULL;
^
The compiler can't tell that we only declared this variable in
order to get the side effect of free'ing it when out of scope.
This pattern is a little dubious for a use of g_autoptr, so
rewrite the code to avoid it.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
ui/clipboard.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/clipboard.c b/ui/clipboard.c
index d7b008d62a..7672058e84 100644
--- a/ui/clipboard.c
+++ b/ui/clipboard.c
@@ -44,12 +44,11 @@ void qemu_clipboard_peer_release(QemuClipboardPeer *peer,
void qemu_clipboard_update(QemuClipboardInfo *info)
{
- g_autoptr(QemuClipboardInfo) old = NULL;
assert(info->selection < QEMU_CLIPBOARD_SELECTION__COUNT);
notifier_list_notify(&clipboard_notifiers, info);
- old = cbinfo[info->selection];
+ qemu_clipboard_info_unref(cbinfo[info->selection]);
cbinfo[info->selection] = qemu_clipboard_info_ref(info);
}
--
2.33.1
- [PATCH v5 00/18] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 03/18] meson: require liburing >= 0.3, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 01/18] ui: avoid compiler warnings from unused clipboard info variable,
Daniel P . Berrangé <=
- [PATCH v5 02/18] spice: Update QXLInterface for spice >= 0.15.0, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 08/18] tests/docker: auto-generate centos8.docker with lcitool, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 09/18] tests/docker: auto-generate fedora.docker with lcitool, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 07/18] tests: integrate lcitool for generating build env manifests, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 10/18] tests/docker: auto-generate ubuntu1804.docker with lcitool, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 05/18] ci: explicitly skip I/O tests on alpine, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 12/18] tests/docker: auto-generate opensuse-leap.docker with lcitool, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 04/18] ui: avoid warnings about directdb on Alpine / musl libc, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 11/18] tests/docker: auto-generate ubuntu2004.docker with lcitool, Daniel P . Berrangé, 2021/12/15
- [PATCH v5 06/18] tests/docker: switch fedora image to release 35, Daniel P . Berrangé, 2021/12/15