[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] monitor: move x-query-profile into accel/tcg to fix build
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3] monitor: move x-query-profile into accel/tcg to fix build |
|
Date: |
Wed, 15 Dec 2021 15:12:50 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/15/21 15:04, Alex Bennée wrote:
> As --enable-profiler isn't defended in CI we missed this breakage.
> Move the qmp handler into accel/tcg so we have access to the helpers
> we need. While we are at it ensure we gate the feature on CONFIG_TCG.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Fixes: 37087fde0e ("qapi: introduce x-query-profile QMP command")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/773
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Message-Id: <20211214195048.1438209-1-alex.bennee@linaro.org>
>
> ---
> v3
> - also add #ifdef CONFIG_TCG to hmp-commands-info.hx
> ---
> qapi/machine.json | 1 +
> accel/tcg/cpu-exec.c | 31 +++++++++++++++++++++++++++++++
> monitor/qmp-cmds.c | 31 -------------------------------
> hmp-commands-info.hx | 2 ++
> 4 files changed, 34 insertions(+), 31 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>