qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] monitor: move x-query-profile into accel/tcg to fix build


From: Daniel P . Berrangé
Subject: Re: [PATCH v2] monitor: move x-query-profile into accel/tcg to fix build
Date: Wed, 15 Dec 2021 09:10:16 +0000
User-agent: Mutt/2.1.3 (2021-09-10)

On Tue, Dec 14, 2021 at 07:50:48PM +0000, Alex Bennée wrote:
> As --enable-profiler isn't defended in CI we missed this breakage.
> Move the qmp handler into accel/tcg so we have access to the helpers
> we need. While we are at it ensure we gate the feature on CONFIG_TCG.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Fixes: 37087fde0e ("qapi: introduce x-query-profile QMP command")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/773
> 
> ---
> v2
>   - enclosed in #ifndef CONFIG_USER_ONLY section
> ---
>  qapi/machine.json    |  1 +
>  accel/tcg/cpu-exec.c | 31 +++++++++++++++++++++++++++++++
>  monitor/qmp-cmds.c   | 31 -------------------------------
>  3 files changed, 32 insertions(+), 31 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Sorry about the mess up I introduced in refactoring, and thanks for
fixing it for me.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]