Re: [PATCH v2 3/4] hw/display/vga-mmio: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO

[Mark Cave-Ayland]

On 13/12/2021 11:05, Philippe Mathieu-Daudé wrote:

> On 12/13/21 11:48, Thomas Huth wrote:
> > On 06/12/2021 23.45, Philippe Mathieu-Daudé wrote:
> > > Introduce TYPE_VGA_MMIO, a sysbus device.
> > >
> > > While there is no change in the vga_mmio_init()
> > > interface, this is a migration compatibility break
> > > of the MIPS Acer Pica 61 Jazz machine (pica61).
> >
> > It's unfortunate, but as far as I know, it would be pretty difficult or
> > even impossible to get this done without versioned machine types? So
> > IMHO it's ok to break this in this case here.
>
> Hervé and Zoltan were already Cc'ed, adding Mark and Finn;
> I am not sure who else would be annoyed by that change.

No issues from this end. I've done a few bits and pieces on the 40p machine when 
testing OpenBIOS, but that won't be affected by this change.


ATB,

Mark.