Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its

From:	Alex Bennée
Subject:	Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd()
Date:	Mon, 13 Dec 2021 14:40:49 +0000
User-agent:	mu4e 1.7.5; emacs 28.0.90

Peter Maydell <peter.maydell@linaro.org> writes:

> Fix process_its_cmd() to consistently return CMD_STALL for
> memory errors and CMD_CONTINUE for parameter errors, as
> we claim in the comments that we do.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 12/26] hw/intc/arm_gicv3_its: Correct comment about CTE RDBase field size, (continued)
- [PATCH 12/26] hw/intc/arm_gicv3_its: Correct comment about CTE RDBase field size, Peter Maydell, 2021/12/11
  - Re: [PATCH 12/26] hw/intc/arm_gicv3_its: Correct comment about CTE RDBase field size, Richard Henderson, 2021/12/12
  - Re: [PATCH 12/26] hw/intc/arm_gicv3_its: Correct comment about CTE RDBase field size, Alex Bennée, 2021/12/13
- [PATCH 17/26] hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention, Peter Maydell, 2021/12/11
  - Re: [PATCH 17/26] hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention, Alex Bennée, 2021/12/13
- [PATCH 23/26] hw/intc/arm_gicv3_its: Fix return codes in process_mapti(), Peter Maydell, 2021/12/11
  - Re: [PATCH 23/26] hw/intc/arm_gicv3_its: Fix return codes in process_mapti(), Richard Henderson, 2021/12/12
  - Re: [PATCH 23/26] hw/intc/arm_gicv3_its: Fix return codes in process_mapti(), Alex Bennée, 2021/12/13
- [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd(), Peter Maydell, 2021/12/11
  - Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd(), Richard Henderson, 2021/12/12
  - Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd(), Alex Bennée <=
- [PATCH 22/26] hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting, Peter Maydell, 2021/12/11
  - Re: [PATCH 22/26] hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting, Richard Henderson, 2021/12/12
  - Re: [PATCH 22/26] hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting, Alex Bennée, 2021/12/13
- [PATCH 26/26] hw/intc/arm_gicv3_its: Factor out "find address of table entry" code, Peter Maydell, 2021/12/11
  - Re: [PATCH 26/26] hw/intc/arm_gicv3_its: Factor out "find address of table entry" code, Richard Henderson, 2021/12/12
  - Re: [PATCH 26/26] hw/intc/arm_gicv3_its: Factor out "find address of table entry" code, Alex Bennée, 2021/12/13
    - Re: [PATCH 26/26] hw/intc/arm_gicv3_its: Factor out "find address of table entry" code, Peter Maydell, 2021/12/13
- [PATCH 13/26] hw/intc/arm_gicv3_its: Use FIELD macros for CTEs, Peter Maydell, 2021/12/11
  - Re: [PATCH 13/26] hw/intc/arm_gicv3_its: Use FIELD macros for CTEs, Richard Henderson, 2021/12/12
  - Re: [PATCH 13/26] hw/intc/arm_gicv3_its: Use FIELD macros for CTEs, Alex Bennée, 2021/12/13

Prev by Date: Re: [PATCH 20/26] hw/intc/arm_gicv3_its: Use enum for return value of process_* functions
Next by Date: Re: [PATCH 19/26] hw/intc/arm_gicv3_its: Don't use data if reading command failed
Previous by thread: Re: [PATCH 21/26] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd()
Next by thread: [PATCH 22/26] hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting
Index(es):
- Date
- Thread