[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] COLO: Move some trace code behind qemu_mutex_unlock_iothread
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH] COLO: Move some trace code behind qemu_mutex_unlock_iothread() |
Date: |
Mon, 13 Dec 2021 11:45:16 +0000 |
User-agent: |
Mutt/2.1.3 (2021-09-10) |
* Rao, Lei (lei.rao@intel.com) wrote:
> Signed-off-by: Lei Rao <lei.rao@intel.com>
You don't say why you want to move it - it's just a trace, what's the
advantage?
Dave
> ---
> migration/colo.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/migration/colo.c b/migration/colo.c
> index 2415325262..3ccacb29c8 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -683,8 +683,8 @@ static void
> colo_incoming_process_checkpoint(MigrationIncomingState *mis,
>
> qemu_mutex_lock_iothread();
> vm_stop_force_state(RUN_STATE_COLO);
> - trace_colo_vm_state_change("run", "stop");
> qemu_mutex_unlock_iothread();
> + trace_colo_vm_state_change("run", "stop");
>
> /* FIXME: This is unnecessary for periodic checkpoint mode */
> colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_REPLY,
> @@ -786,8 +786,8 @@ static void
> colo_incoming_process_checkpoint(MigrationIncomingState *mis,
>
> vmstate_loading = false;
> vm_start();
> - trace_colo_vm_state_change("stop", "run");
> qemu_mutex_unlock_iothread();
> + trace_colo_vm_state_change("stop", "run");
>
> if (failover_get_state() == FAILOVER_STATUS_RELAUNCH) {
> return;
> @@ -870,8 +870,8 @@ void *colo_process_incoming_thread(void *opaque)
> abort();
> #endif
> vm_start();
> - trace_colo_vm_state_change("stop", "run");
> qemu_mutex_unlock_iothread();
> + trace_colo_vm_state_change("stop", "run");
>
> colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_READY,
> &local_err);
> --
> 2.32.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK