|
From: | Alex Bennée |
Subject: | Re: [PATCH 06/26] hw/intc/arm_gicv3_its: Reduce code duplication in extract_table_params() |
Date: | Mon, 13 Dec 2021 11:34:57 +0000 |
User-agent: | mu4e 1.7.5; emacs 28.0.90 |
Peter Maydell <peter.maydell@linaro.org> writes: > The extract_table_params() decodes the fields in the GITS_BASER<n> > registers into TableDesc structs. Since the fields are the same for > all the GITS_BASER<n> registers, there is currently a lot of code > duplication within the switch (type) statement. Refactor so that the > cases include only what is genuinely different for each type: > the calculation of the number of bits in the ID value that indexes > into the table. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> -- Alex Bennée
[Prev in Thread] | Current Thread | [Next in Thread] |