[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] MIPS - fix cycle counter timing calculations

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] MIPS - fix cycle counter timing calculations
Date: Mon, 13 Dec 2021 11:23:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0

On 12/13/21 11:10, Philippe Mathieu-Daudé wrote:
> On 11/16/21 08:26, Simon Burge wrote:
>> The cp0_count_ns value is calculated from the CP0_COUNT_RATE_DEFAULT
>> constant in target/mips/cpu.c.  The cycle counter resolution is defined
>> per-CPU in target/mips/cpu-defs.c.inc; use this value for calculating
>> cp0_count_ns.  Fixings timing problems on guest OSs for the 20Kc CPU
>> which has a CCRes of 1.
>> ---
>>  target/mips/cpu.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> Good catch. Too bad you didn't Cc'ed the maintainers, this patch
> would have been in the 6.2 release.
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Queued to mips-next.

Oops, missing your Signed-off-by tag, see:

Do you mind re-sending with your S-o-b? Meanwhile, patch dropped.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]