Re: [PATCH v8 0/4] tests/qtest: add some tests for virtio-net failover

[Thomas Huth]

On 08/12/2021 14.03, Laurent Vivier wrote:
> This series adds a qtest entry to test virtio-net failover feature.
>
> We check following error cases:
>
> - check missing id on device with failover_pair_id triggers an error
> - check a primary device plugged on a bus that doesn't support hotplug
>    triggers an error
>
> We check the status of the machine before and after hotplugging cards and
> feature negotiation:
>
> - check we don't see the primary device at boot if failover is on
> - check we see the primary device at boot if failover is off
> - check we don't see the primary device if failover is on
>    but failover_pair_id is not the one with on (I think this should be changed)
> - check the primary device is plugged after the feature negotiation
> - check the result if the primary device is plugged before standby device and
>    vice-versa
> - check the if the primary device is coldplugged and the standy device
>    hotplugged and vice-versa
> - check the migration triggers the unplug and the hotplug
>
> There is one preliminary patch in the series:
>
> - PATCH 1 introduces a function to enable PCI bridge.
>    Failover needs to be plugged on a pcie-root-port and while
>    the root port is not configured the cards behind it are not
>    available
>
> v8:
> - fix checkpatch.pl error (space after "(")
> - fix sanitizer errors:
>    * migrate_status() qobject_unref() cleanup
>    * release QVirtioPCIDevice with qos_object_destroy()
>    * add a missing g_free() in qpci_secondary_buses_rec()
>    * add qobject_unref() in get_bus() and find_device()
>      when an object is popped from a list.

Thanks, CI is green now, so queued it to my testing-next branch:

 https://gitlab.com/thuth/qemu/-/commits/testing-next/

 Thomas