Re: [RFC v3 12/19] vfio-user: region read/write

[John Johnson]

> On Nov 19, 2021, at 2:42 PM, Alex Williamson <alex.williamson@redhat.com> 
> wrote:
> 
> On Mon,  8 Nov 2021 16:46:40 -0800
> John Johnson <john.g.johnson@oracle.com> wrote:
> 
>> 
>> VFIOProxy *vfio_user_connect_dev(SocketAddress *addr, Error **errp);
>> void vfio_user_disconnect(VFIOProxy *proxy);
>> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
>> index e2d7ee1..b498964 100644
>> --- a/include/hw/vfio/vfio-common.h
>> +++ b/include/hw/vfio/vfio-common.h
>> @@ -56,6 +56,7 @@ typedef struct VFIORegion {
>>     uint32_t nr_mmaps;
>>     VFIOMmap *mmaps;
>>     uint8_t nr; /* cache the region number for debug */
>> +    bool post_wr; /* writes can be posted */
> 
> As with the fd in the previous patch, this is where the concept of
> posted writes should be introduced throughout.  Or maybe even better
> would be to introduce write support without posting and the next patch
> could expose posted writes.  Thanks,
> 

        I can place it with the region write ops patch where it’s used.

                                                        JJ