[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 1/1] tcg/arm: Reduce vector alignment requirement for
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for-6.2 1/1] tcg/arm: Reduce vector alignment requirement for NEON |
|
Date: |
Mon, 6 Dec 2021 21:11:37 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/6/21 20:13, Richard Henderson wrote:
> With arm32, the ABI gives us 8-byte alignment for the stack.
> While it's possible to realign the stack to provide 16-byte alignment,
> it's far easier to simply not encode 16-byte alignment in the
> VLD1 and VST1 instructions that we emit.
>
> Remove the assertion in temp_allocate_frame, limit natural alignment
> to the provided stack alignment, and add a comment.
>
> Reported-by: Richard W.M. Jones <rjones@redhat.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Message-Id: <20210912174925.200132-1-richard.henderson@linaro.org>
> ---
> tcg/tcg.c | 8 +++++++-
> tcg/arm/tcg-target.c.inc | 13 +++++++++----
> 2 files changed, 16 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>