[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for 6.2? v2] Revert "vga: don't abort when adding a duplicate
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for 6.2? v2] Revert "vga: don't abort when adding a duplicate isa-vga device" |
|
Date: |
Mon, 6 Dec 2021 11:50:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/6/21 11:43, Philippe Mathieu-Daudé wrote:
> On 12/6/21 10:52, Alex Bennée wrote:
>> This reverts commit 7852a77f598635a67a222b6c1463c8b46098aed2.
>>
>> The check is bogus as it ends up finding itself and falling over.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/733
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>> Message-Id: <20211202164929.1119036-1-alex.bennee@linaro.org>
>>
>> ---
>> v2
>> - fixed bug link
>
> IIUC Cornelia & Mark said the correct fix is simply:
>
> -- >8 --
> - if (object_resolve_path_type("", TYPE_ISA_VGA, NULL)) {
> + if (!object_resolve_path_type("", TYPE_ISA_VGA, NULL)) {
> ---
Bah I just noticed your update on v1:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg854596.html
So:
Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
and queued to mips-fixes, thanks.